Check admin endpoint instead of metrics for Pulsar WaitStrategy. #5514
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Besides the suggestion, my little concern is related to METRIC_ENDPOINT (which I am not expecting to be used) can break someone else code. I would rather deprecate it for now.
Would like to hear from @kiview @bsideup regarding to this.
In case, we agree to drop it. The following is needed in the build.gradle file in the pulsar module
tasks.japicmp {
fieldExcludes = [
"org.testcontainers.containers.PulsarContainer#METRICS_ENDPOINT"
]
}
modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java
Outdated
Show resolved
Hide resolved
…sarContainer.java Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
nahguam
force-pushed
the
pulsar-wait-strategy
branch
from
2da64cf to
85adce5
Compare
|
I agree with @eddumelendez's argument and that's how we generally approach changes to the public API. So although unlikely that users depend on it, let's deprecate |
bsideup
reviewed
Jun 24, 2022
modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java
Show resolved
Hide resolved
kiview
approved these changes
Jun 24, 2022
modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java
Outdated
Show resolved
Hide resolved
…sarContainer.java Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
bsideup
approved these changes
Jun 28, 2022
|
@nahguam thanks for your contribution! this is now in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5513