Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check admin endpoint instead of metrics for Pulsar WaitStrategy. #5514

Merged
merged 5 commits into from Jun 28, 2022

Conversation

nahguam
Copy link
Contributor

@nahguam nahguam commented Jun 22, 2022

Fixes #5513

@nahguam nahguam requested a review from a team as a code owner June 22, 2022 15:33
@kiview kiview added this to the next milestone Jun 22, 2022
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the suggestion, my little concern is related to METRIC_ENDPOINT (which I am not expecting to be used) can break someone else code. I would rather deprecate it for now.

Would like to hear from @kiview @bsideup regarding to this.

In case, we agree to drop it. The following is needed in the build.gradle file in the pulsar module

tasks.japicmp {
    fieldExcludes = [
        "org.testcontainers.containers.PulsarContainer#METRICS_ENDPOINT"
    ]
}

Dave Maughan and others added 2 commits June 23, 2022 14:33
@kiview
Copy link
Member

kiview commented Jun 23, 2022

I agree with @eddumelendez's argument and that's how we generally approach changes to the public API. So although unlikely that users depend on it, let's deprecate METRIC_ENDPOINT to be safe.

…sarContainer.java

Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@eddumelendez eddumelendez merged commit 56d0cf1 into testcontainers:master Jun 28, 2022
@eddumelendez
Copy link
Member

@nahguam thanks for your contribution! this is now in master

@nahguam nahguam deleted the pulsar-wait-strategy branch June 28, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Better WaitStrategy to ensure the Pulsar cluster is fully initialised
4 participants