Add TiDB module #5511

Icemap · 2022-06-21T04:35:04Z

Add TiDB test container support.

Icemap · 2022-06-24T07:30:31Z

PTAL @eddumelendez @kiview

Icemap · 2022-07-20T10:09:02Z

One month passed, PTAL.

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java

…o feat-tidb

kiview · 2022-07-20T13:24:08Z

Hey @Icemap, thank you for the contribution, we did not yet have time to review it, sorry.

kiview · 2022-07-20T13:35:28Z

Please run ./gradlew :tidb:spotlessApply to fix the spotless errors.

modules/tidb/src/main/resources/mysql-default-conf/my.cnf

eddumelendez

thanks for the pr @Icemap ! I've left some comments

...main/resources/META-INF/services/org.testcontainers.containers.JdbcDatabaseContainerProvider

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java

eddumelendez · 2022-07-20T21:20:50Z

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java

+        super(dockerImageName);
+        dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME);
+
+        addExposedPorts(TIDB_PORT, REST_API_PORT);


both ports should be exposed? or only 4000?

Both ports should be exposed. TIDB_PORT is 4000, and REST_API_PORT is 10080.

modules/tidb/src/test/java/org/testcontainers/junit/tidb/SimpleTiDBTest.java

modules/tidb/build.gradle

Icemap · 2022-07-21T03:49:05Z

Please run ./gradlew :tidb:spotlessApply to fix the spotless errors.

@kiview Thanks for the review. And I got this error diffplug/spotless#834 at Java 17 when I run ./gradlew :tidb:spotlessApply. According to this issue. I added this line at gradle.properties:

org.gradle.jvmargs=--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED

gradle.properties

modules/tidb/build.gradle

...main/resources/META-INF/services/org.testcontainers.containers.JdbcDatabaseContainerProvider

bsideup · 2022-08-04T10:55:48Z

@eddumelendez does this PR need to change .github/labeler.yml / .github/ISSUE_TEMPLATE/enhancement.yaml / .github/ISSUE_TEMPLATE/feature.yaml / .github/ISSUE_TEMPLATE/bug_report.yaml / .github/dependabot.yml ?

[maintainers note] can we automate the check for new modules somehow?

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java

…ontainer.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>

modules/tidb/src/test/java/org/testcontainers/junit/tidb/SimpleTiDBTest.java

kiview · 2022-08-04T13:58:41Z

@bsideup Yes, we need to touch those with new modules. We can take care of this for now.

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java

…ontainer.java

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java

…o feat-tidb

kiview · 2022-08-12T08:13:45Z

Thanks a lot for all your work @Icemap. I saw you recently started to do some more commits. Are we good to go from your side or is there something you want to work on a bit more?

kiview · 2022-08-12T08:36:19Z

./gradlew :tidb:spotlessApply to fix Spotless, sorry.

Icemap · 2022-08-15T05:28:48Z

Recently commits were to fix CI errors. @kiview

kiview · 2022-08-15T14:02:06Z

Merged, thanks for the great contribution and collaboration @Icemap 🙌

Icemap added 2 commits June 20, 2022 18:47

[Update] Support TiDB

4de91a2

[Update] TiDB documents

1d0d360

Icemap requested a review from a team as a code owner June 21, 2022 04:35

Merge branch 'master' into feat-tidb

5248596

kiview added type/new module modules/jdbc labels Jun 21, 2022

Merge branch 'master' into feat-tidb

94232f6

github-actions bot added type/docs and removed modules/jdbc labels Jul 20, 2022

pioorg reviewed Jul 20, 2022

View reviewed changes

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java Outdated Show resolved Hide resolved

pioorg reviewed Jul 20, 2022

View reviewed changes

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java Outdated Show resolved Hide resolved

Icemap added 2 commits July 20, 2022 18:31

[Update] correct author and remove deprecated annotation

e36bdb0

Merge branch 'feat-tidb' of github.com:Icemap/testcontainers-java int…

1fb60bd

…o feat-tidb

kiview reviewed Jul 20, 2022

View reviewed changes

modules/tidb/src/main/resources/mysql-default-conf/my.cnf Outdated Show resolved Hide resolved

eddumelendez requested changes Jul 20, 2022

View reviewed changes

[Update] format TiDB code and adapt Java 17

bc8307a

Icemap added 2 commits July 21, 2022 11:52

[Delete] no used file: my.cnf

d813e4e

[Debug] rollback changed mysql meta file

e987819

eddumelendez reviewed Jul 21, 2022

View reviewed changes

gradle.properties Outdated Show resolved Hide resolved

Icemap added 3 commits July 21, 2022 12:34

[Update] consistent with the other containers by using image string

b32059c

[Delete] close LogManager code

baa25c1

[Rollback] adapt props for Java 17

f1bdcfe

eddumelendez reviewed Jul 21, 2022

View reviewed changes

modules/tidb/build.gradle Outdated Show resolved Hide resolved

...main/resources/META-INF/services/org.testcontainers.containers.JdbcDatabaseContainerProvider Outdated Show resolved Hide resolved

Icemap added 2 commits July 22, 2022 10:50

[Rollback] org.testcontainers.containers.JdbcDatabaseContainerProvider

c31114a

[Delete] r2dbc on test scope

84f8d0d

bsideup reviewed Aug 4, 2022

View reviewed changes

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java Outdated Show resolved Hide resolved

bsideup reviewed Aug 4, 2022

View reviewed changes

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java Outdated Show resolved Hide resolved

kiview and others added 2 commits August 4, 2022 15:54

Update modules/tidb/src/main/java/org/testcontainers/containers/TiDBC…

d4e8554

…ontainer.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>

Update modules/tidb/src/main/java/org/testcontainers/containers/TiDBC…

7eb23eb

…ontainer.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>

kiview reviewed Aug 4, 2022

View reviewed changes

modules/tidb/src/test/java/org/testcontainers/junit/tidb/SimpleTiDBTest.java Outdated Show resolved Hide resolved

kiview approved these changes Aug 4, 2022

View reviewed changes

kiview and others added 3 commits August 4, 2022 16:06

Make NAME and DOCKER_IMAGE_NAME package-protected

e4522e7

Add TiDB module to GH automation

eb72033

[Update] init_mysql.sql -> init_tidb.sql

c6ff27d

eddumelendez reviewed Aug 4, 2022

View reviewed changes

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java Outdated Show resolved Hide resolved

eddumelendez and others added 3 commits August 4, 2022 09:39

Update modules/tidb/src/main/java/org/testcontainers/containers/TiDBC…

8f692be

…ontainer.java

Fix spotless

c0df0f0

Merge branch 'master' into feat-tidb

cc56713

eddumelendez changed the title ~~Support TiDB~~ Add TiDB module Aug 6, 2022

kiview requested changes Aug 8, 2022

View reviewed changes

modules/tidb/src/main/java/org/testcontainers/containers/TiDBContainer.java Outdated Show resolved Hide resolved

Icemap added 2 commits August 12, 2022 12:53

[Rename] org.testcontainers.containers -> org.testcontainers.tidb

c16aa77

Merge branch 'master' into feat-tidb

bc5c9a5

kiview approved these changes Aug 12, 2022

View reviewed changes

Icemap added 3 commits August 12, 2022 14:57

[Unit Test] static import only from classes and interfaces

5d4355b

Merge branch 'feat-tidb' of github.com:Icemap/testcontainers-java int…

a25384a

…o feat-tidb

[Debug] import wrong package

6f2c6a7

[Debug] spotlessApply

680075b

kiview merged commit 54d7f39 into testcontainers:master Aug 15, 2022

kiview removed the type/docs label Aug 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TiDB module #5511

Add TiDB module #5511

Icemap commented Jun 21, 2022 •

edited

Icemap commented Jun 24, 2022

Icemap commented Jul 20, 2022

kiview commented Jul 20, 2022

kiview commented Jul 20, 2022

eddumelendez left a comment

eddumelendez Jul 20, 2022 •

edited

Icemap Jul 21, 2022

Icemap commented Jul 21, 2022

bsideup commented Aug 4, 2022

kiview commented Aug 4, 2022 •

edited

kiview commented Aug 12, 2022

kiview commented Aug 12, 2022

Icemap commented Aug 15, 2022

kiview commented Aug 15, 2022

Add TiDB module #5511

Add TiDB module #5511

Conversation

Icemap commented Jun 21, 2022 • edited

Icemap commented Jun 24, 2022

Icemap commented Jul 20, 2022

kiview commented Jul 20, 2022

kiview commented Jul 20, 2022

eddumelendez left a comment

Choose a reason for hiding this comment

eddumelendez Jul 20, 2022 • edited

Choose a reason for hiding this comment

Icemap Jul 21, 2022

Choose a reason for hiding this comment

Icemap commented Jul 21, 2022

bsideup commented Aug 4, 2022

kiview commented Aug 4, 2022 • edited

kiview commented Aug 12, 2022

kiview commented Aug 12, 2022

Icemap commented Aug 15, 2022

kiview commented Aug 15, 2022

Icemap commented Jun 21, 2022 •

edited

eddumelendez Jul 20, 2022 •

edited

kiview commented Aug 4, 2022 •

edited