Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StackOverflowError in DockerClientFactory#client #5262

Merged
merged 1 commit into from Apr 13, 2022
Merged

Fix StackOverflowError in DockerClientFactory#client #5262

merged 1 commit into from Apr 13, 2022

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Apr 13, 2022 •
edited

We need to set the client variable before anything else, and the log line accidentally slipped before client is set.

Fixes #5261

@bsideup bsideup added this to the next milestone Apr 13, 2022
@bsideup bsideup mentioned this pull request Apr 13, 2022
Closed
@bsideup bsideup merged commit 66e4be2 into master Apr 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_recursion branch April 13, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.17.1
Development

Successfully merging this pull request may close these issues.

1.17.0 StackOverflowError in resolveDockerHostIpAddress
2 participants
@bsideup @kiview