removed hardcoded log level setting on mockserver #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @szymonprz, thanks for the PR. This is indeed a very useful housekeeping chage. |
kiview
approved these changes
Dec 22, 2021
bsideup
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pr is only a housekeeping, because by default logLevel of mockserver is set to INFO https://github.com/mock-server/mockserver/blob/master/mockserver-core/src/main/java/org/mockserver/configuration/ConfigurationProperties.java#L39
and by setting this log level this way (through command line arg), we cannot change it later on the client side code of MockserverContainer by env variable "MOCKSERVER_LOG_LEVEL" so this change also allows to change log level of mockserver