Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily disable Thundra on master branch" #4571

Merged
merged 4 commits into from Oct 21, 2021
Merged

Revert "Temporarily disable Thundra on master branch" #4571

merged 4 commits into from Oct 21, 2021

Conversation

rwxdash
Copy link
Contributor

@rwxdash rwxdash commented Oct 12, 2021

Reverts #4570

@rwxdash rwxdash marked this pull request as ready for review October 12, 2021 09:46
@rnorth
Copy link
Member

rnorth commented Oct 12, 2021

As discussed on Slack, @rwxdash is preparing this PR so that we can re-enable Thundra (with some improvements).

kiview
kiview requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not allow running PRs without Thundra it seems?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@rnorth
Copy link
Member

rnorth commented Oct 14, 2021

I think we should merge this one after our release, rather than before.

@rnorth rnorth merged commit e122628 into testcontainers:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

Assignees
No one assigned
Labels
type/test-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwxdash @rnorth @kiview