Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter mapped ports when port numbers are not specified (replaces #3948) #3979

Merged
merged 6 commits into from Apr 11, 2021
Merged

Filter mapped ports when port numbers are not specified (replaces #3948) #3979

merged 6 commits into from Apr 11, 2021

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Apr 11, 2021

From @wrover's description:

This fixes the issue which happens on some verisons of docker on some platforms (particulalrly, on macOS X) when port mapping comes in form of 0.0.0.0:0:80.

#3923 seems to be a direct occurrence of this problem, and we need to resolve quickly.

@rnorth rnorth marked this pull request as draft April 11, 2021 16:26
@rnorth rnorth mentioned this pull request Apr 11, 2021
Closed
@rnorth rnorth marked this pull request as ready for review April 11, 2021 16:30
@bsideup bsideup added this to the next milestone Apr 11, 2021
@rnorth rnorth merged commit 1e6deb1 into master Apr 11, 2021
@rnorth rnorth deleted the wrover/filter-meaningless-bindings branch April 11, 2021 18:54
@rnorth rnorth mentioned this pull request Apr 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnorth @bsideup @euonymos