-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Shaded Jackson Annotations Dependency #3972
Comments
jackson-annotation is intentionally not shaded, as part of docker-java-api. Make sure that there is nothing that forces it to some super old version, since |
Thanks @bsideup. Yes unfortunately my project has an older version of Jackson. I anticipated it was ok because of the "Shaded Dependencies" image attached above. Can the website be updated to reflect that not all Jackson libs are shaded? This was confusing as a user since it is saying "these libraries are 'shaded' into the core testcontainers JAR" but not all are intentionally shaded. |
@jsurls you made a good discovery that that block is slightly outdated 😅 Thanks, we will reflect the last state 👍 |
I just submitted #3974 to make it less confusing. Thanks for telling us! 💯 |
I have a basic test using the Scala testcontainers lib starting a MySQL Container.
My two dependencies transitively point me to version
org.testcontainers:testcontainers:jar:1.15.2:test
The testcontainers website advertises that all Jackson libs are shaded to prevent issues:
However it appears the MapperConfig is calling out to an unshaded Jackson Annotations lib:
Reverting back to version
org.testcontainers:testcontainers:jar:1.14.3:test
works for me.I believe this might be the cause for the omission of Jackson Annotations from being shaded:
https://github.com/testcontainers/testcontainers-java/blame/8965712f239ae3c449cec579264af5e79265f314/core/build.gradle#L188
Looking at #2882, was Jackson Annotations intended to be omitted?
The text was updated successfully, but these errors were encountered: