Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docker command of cockroachDB module #3608

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

giger85
Copy link
Contributor

@giger85 giger85 commented Dec 16, 2020

This PR resolves #3571

Caveat

  • Before v19.1.x version, start-single-node command does not work.

Issue: testcontainers#3571
This also includes changing default tag version (to v19.2.11)
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: accidentally clicked the approve button 😬

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be problematic - it will mean that people who are using the default constructor in their tests will suddenly receive a different version of the container.

This is outlined further in #3381.

Also, we'll have a problem if start-single-node is not backwards compatible with older versions if CockroachDB. We can't break peoples' tests if they explicitly need to use older versions. Is it backwards compatible?

@giger85
Copy link
Contributor Author

giger85 commented Jan 2, 2021

@rnorth
As #3571, current default tag version (v19.1.x) reached EOL and v20.2.x version is not working.

Since this module is incubating module, I thought this change is acceptable.
But start-single-node is not backward compatible command, I will try to find backward compatible solution.

Thanks for your review.

@bsideup bsideup added this to the next milestone Feb 6, 2021
@bsideup
Copy link
Member

bsideup commented Feb 6, 2021

@rnorth given the deprecated version and default tag being changed, I think we're good to go :) Will merge :)

Note that old versions can still be used by overriding the command, so we're not blocking the usage of them, just raising the minimal version requirement (again, since v19.1.x is EOL)

@bsideup bsideup merged commit 140fd94 into testcontainers:master Feb 6, 2021
@giger85
Copy link
Contributor Author

giger85 commented Feb 16, 2021

@bsideup
Thanks for your review.
This change helps for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in CockroachDB CLI interface for versions 20.2+.*
3 participants