Move away from using quay.io for default images #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
commented
May 28, 2020
core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java
Show resolved
Hide resolved
bsideup
reviewed
May 28, 2020
| @@ -72,11 +72,11 @@ public boolean isRyukPrivileged() { | |||
| } | |||
|
|
|||
| public String getRyukImage() { | |||
| return (String) properties.getOrDefault("ryuk.container.image", "quay.io/testcontainers/ryuk:0.2.3"); | |||
| return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:latest"); | |||
There was a problem hiding this comment.
Suggested change
| return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:latest"); | |
| return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:0.3.0"); |
There was a problem hiding this comment.
Yep, now that it's published 😆
bsideup
reviewed
May 28, 2020
docs/features/configuration.md
Outdated
|
|
||
| ## Customizing Ryuk resource reaper | ||
|
|
||
| > **ryuk.container.image = quay.io/testcontainers/ryuk:0.2.3** | ||
| > **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** |
There was a problem hiding this comment.
Suggested change
| > **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** | |
| > **ryuk.container.image = testcontainersoffical/ryuk:0.3.0** |
Closed
slovdahl
reviewed
May 28, 2020
docs/features/configuration.md
Outdated
| @@ -32,7 +32,7 @@ Some companies disallow the usage of Docker Hub, but you can override `*.image` | |||
| > **tinyimage.container.image = alpine:3.5** | |||
| > Used by Testcontainers' core | |||
|
|
|||
| > **vncrecorder.container.image = quay.io/testcontainers/vnc-recorder:1.1.0** | |||
| > **vncrecorder.container.image = testcontainersoffical/vnc-recorder:1.1.0** | |||
There was a problem hiding this comment.
Should it be testcontainersofficial?
docs/features/configuration.md
Outdated
|
|
||
| ## Customizing Ryuk resource reaper | ||
|
|
||
| > **ryuk.container.image = quay.io/testcontainers/ryuk:0.2.3** | ||
| > **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** |
perlun
approved these changes
May 28, 2020
bsideup
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.