Ensure that ParsedDockerfile supports platform args #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2772 Also make parsing case insensitive, for better compliance with Dockerfile spec
bsideup
reviewed
May 26, 2020
| @@ -40,6 +46,12 @@ public void ignoringBuildStageNames() { | |||
| assertEquals("ignores build stage names and allows multiple images to be extracted", Sets.newHashSet("someimage", "nextimage"), parsedDockerfile.getDependencyImageNames()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void ignoringPlatformArgs() { | |||
| final ParsedDockerfile parsedDockerfile = new ParsedDockerfile(asList("FROM --platform=linux/amd64 someimage", "RUN something")); | |||
There was a problem hiding this comment.
since the parsing seem to support multiple flags, perhaps we should add this (2 or more flags) case too
There was a problem hiding this comment.
Platform seems to be the only arg that is supported by docker at present, but sure, seems like a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2772
Also make parsing case insensitive, for better compliance with Dockerfile spec