Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version #2757 #2758

Merged
merged 1 commit into from May 22, 2020
Merged

Conversation

AElMehdi
Copy link
Contributor

Not much of a contribution, but it's an honest work though 馃槄

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槂 thanks @AElMehdi
I really need to fix our automation for this..!

@rnorth rnorth merged commit 289fb50 into testcontainers:master May 22, 2020
@AElMehdi
Copy link
Contributor Author

My pleasure @rnorth 馃檹.
Any hints on how we can fix that? I'll be glad to work on it!

@rnorth
Copy link
Member

rnorth commented May 23, 2020

If you could, that'd be great!

This file: https://github.com/testcontainers/testcontainers-java/blob/master/.github/workflows/update-docs-version.yml needs to be made to... actually work 馃槀

The problem is that the push step (here) doesn't actually have permissions to push to master, as it's a protected branch. We're not going to be able to make it bypass and push direct to master.

Instead, we should use a GitHub Action that is capable of raising a PR. This one looks nice and easy to use: https://github.com/peter-evans/create-pull-request

If you'd be able to have a go at this, it would be much appreciated. This is one of those annoying things that really should be automated!

@AElMehdi AElMehdi deleted the update_version_doc branch May 23, 2020 23:26
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants