couchbase: wait until query engine knows about bucket before creating… #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
requested changes
May 7, 2020
| // If the query service is enabled, make sure that we only proceed if the query engine also | ||
| // knows about the bucket in its metadata configuration. | ||
| Unreliables.retryUntilTrue(1, TimeUnit.MINUTES, () -> { | ||
| Response queryResponse = doHttpRequest(QUERY_PORT, "/query/service", "POST", new FormBody.Builder() |
There was a problem hiding this comment.
Just a thought: all these Response objects ought to be closed (here and elsewhere). Otherwise we'll potentially be holding connections open on the client and server side.
This is probably much more important inside a retryUntilTrue invocation, as the frequency of retries could be high.
Lombok's @Cleanup annotation would be a cheap and easy way to ensure that these response objects get cleaned up.
There was a problem hiding this comment.
sorry that I've been slow on this. Working on it now, will update the PR
… primary index The motivation for this change is that in slow environments, it could be that the query engine is not aware of the just created bucket yet and so the create primary index will take longer than the 10s read timeout for the subsequent http request. As a result, this is just another precaution to minimize the chances that in slow environments the create primary index call times out with a read timeout.
daschl
force-pushed
the
query-keyspace-check
branch
from
b78068d
to
cd1543e
Compare
bsideup
approved these changes
May 28, 2020
rnorth
approved these changes
May 29, 2020
sd-yip
added a commit
to sd-yip/testcontainers-java
that referenced
this pull request
May 12, 2021
…creating… (testcontainers#2662)" This reverts commit 835ac71.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… primary index
The motivation for this change is that in slow environments, it could be that the
query engine is not aware of the just created bucket yet and so the create primary
index will take longer than the 10s read timeout for the subsequent http request.
As a result, this is just another precaution to minimize the chances that in
slow environments the create primary index call times out with a read timeout.