Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI docs: fix invalid executor key #2607

Merged
merged 1 commit into from Apr 23, 2020

Conversation

fernfernfern
Copy link
Contributor

@fernfernfern fernfernfern commented Apr 23, 2020

executorType is no longer a valid executor definition in CircleCI. The simplest form to designate using machine executor is machine: true. Here is an example usage in the current docs.

executorType is no longer a valid executor definition. The simplest form to designate using machine executor is `machine: true`
@rnorth rnorth changed the title fix invalid executor key CircleCI docs: fix invalid executor key Apr 23, 2020
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this, @fernfernfern!

@rnorth rnorth merged commit 4d17308 into testcontainers:master Apr 23, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
executorType is no longer a valid executor definition. The simplest form to designate using machine executor is `machine: true`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants