Use relative path for temp dirs in test #2604
Merged
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Raised #2606 so we don’t forget to track down the root cause. |
bsideup
reviewed
Apr 23, 2020
core/src/test/java/org/testcontainers/utility/AuthenticatedImagePullTest.java
Show resolved
Hide resolved
|
/azp run Windows 10 - Docker for Windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bsideup
reviewed
Apr 23, 2020
core/src/test/java/org/testcontainers/utility/AuthenticatedImagePullTest.java
Show resolved
Hide resolved
kiview
reviewed
Apr 23, 2020
core/src/test/java/org/testcontainers/utility/AuthenticatedImagePullTest.java
Show resolved
Hide resolved
rnorth
force-pushed
the
fix-windows-authpull-test-failure
branch
from
04bfb00 to
d081dbd
Compare
bsideup
approved these changes
Apr 23, 2020
kiview
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't fully understand,
DockerComposeContaineris failing to mount a directory when passed the absolute path form of temporary files created inAuthenticatedImagePullTest.This only seems to happen on our Windows CI box, and I cannot reproduce locally on a Windows machine.
Converting the temp file path to relative form fixes the CI failure.
We should work out how this issue was occurring as it seems like there's a small bug lurking somewhere. But as this is the first known occurrence, I think it's safe to assume it's a pretty rare problem.