Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradle caching to find_gradle_jobs build #2589

Merged
merged 5 commits into from Apr 18, 2020
Merged

Add gradle caching to find_gradle_jobs build #2589

merged 5 commits into from Apr 18, 2020

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Apr 18, 2020

No description provided.

bsideup
bsideup reviewed Apr 18, 2020
View reviewed changes
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... right! Good catch 👍

@bsideup
Copy link
Member

bsideup commented Apr 18, 2020

@rnorth could you please make a change in some shared module (e.g. r2dbc) to test that as well?

@rnorth
Copy link
Member Author

rnorth commented Apr 18, 2020 •
edited

😄

Will do.

(for just a no-op blank commit):
Looks like this reduces the testMatrix task from taking >2mins to 20-ish seconds. There is an additional 30s spent restoring the gradle home cache, but we're still saving a minute this way!

@rnorth
Copy link
Member Author

rnorth commented Apr 18, 2020

With a dummy change in the r2dbc module:
image

@rnorth rnorth marked this pull request as ready for review April 18, 2020 14:12
@rnorth rnorth requested a review from kiview as a code owner April 18, 2020 14:12
@rnorth rnorth added this to the next milestone Apr 18, 2020
@rnorth rnorth merged commit 374c559 into master Apr 18, 2020
@rnorth rnorth deleted the faster-testmatrix branch April 18, 2020 15:07
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
@rnorth @quincy
Add gradle caching to find_gradle_jobs build (testcontainers#2589)
3264b47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnorth @bsideup