Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude multi-module module-info.class from shaded JAR #2588

Merged
merged 1 commit into from Apr 18, 2020
Merged

Exclude multi-module module-info.class from shaded JAR #2588

merged 1 commit into from Apr 18, 2020

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Apr 18, 2020

Similar to 8dede04

@rnorth
Copy link
Member Author

rnorth commented Apr 18, 2020

I've excluded the module-info.class which was leaking into the JAR via the META-INF/versions (multi module JAR) route.

I chose not to exclude the entire versions directory, because it would probably be valid for non-module-info classes to end up being shaded there at some point, and excluding those classes entirely may be bad news.

There's nothing yet in there, though. We'll also need to update the test if and when that changes.

@rnorth rnorth merged commit e7230c2 into master Apr 18, 2020
@rnorth rnorth deleted the fix-shaded-jar branch April 18, 2020 13:23
@rnorth rnorth added this to the next milestone Apr 18, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
@rnorth @quincy
Exclude multi-module module-info.class from shaded JAR (testcontain…
56d46a6 
…ers#2588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnorth @bsideup