Public ImageData class for custom image pull policies #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
policies. Adding test to ensure it works as expected.
|
@cha55son we had some CI problems which are fixed on master, so I've updated the branch! Thanks. |
bsideup
reviewed
Apr 18, 2020
core/src/test/java/alt/testcontainers/images/OutOfPackageImagePullPolicyTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 18, 2020
core/src/test/java/alt/testcontainers/images/OutOfPackageImagePullPolicyTest.java
Outdated
Show resolved
Hide resolved
container image for the out of package pull policy test.
bsideup
approved these changes
Apr 19, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…iners#2585) * Making imagedata public so it can be used to create custom image pull policies. Adding test to ensure it works as expected. * Ensuring we don't do unnecessary pulls and using the default generic container image for the out of package pull policy test. Co-authored-by: Chason Choate <chason.choate@digitalreasoning.com> Co-authored-by: Richard North <rich.north@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following the docs here: https://www.testcontainers.org/features/advanced_options/#image-pull-policy for creating a custom pull policy. It wouldn't let me compile since the
ImageDataclass was not public. This PR makes that class public and provides a test to ensureImageDatacan be accessed outside theorg.testcontainers.imagespackage.