Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateContainerCmd Link was outdated. #2583

Merged
merged 3 commits into from Apr 17, 2020

Conversation

KraTos5589
Copy link
Contributor

Replaced working link

@bsideup
Copy link
Member

bsideup commented Apr 17, 2020

@KraTos5589 nice! Could you please use versioned link, to avoid a breakage in future? :)

@bsideup bsideup added this to the next milestone Apr 17, 2020
@KraTos5589
Copy link
Contributor Author

@bsideup Done

@bsideup
Copy link
Member

bsideup commented Apr 17, 2020

@KraTos5589 3.0.0 is a bit old, please update to the latest release (3.2.1)

@KraTos5589
Copy link
Contributor Author

@bsideup Updated to 3.2.1

Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsideup bsideup merged commit b7cda9d into testcontainers:master Apr 17, 2020
@KraTos5589
Copy link
Contributor Author

KraTos5589 commented Apr 17, 2020

Yea first github PR merged.

@bsideup
Copy link
Member

bsideup commented Apr 17, 2020

@KraTos5589 thank you and congratulations! 🎉
we will try to find time to look at your another (Cassandra) PR soon! 👍

@KraTos5589
Copy link
Contributor Author

Thabks @bsideup , I thought you forgot about that.

@bsideup
Copy link
Member

bsideup commented Apr 17, 2020

@KraTos5589 we never forget about PRs, it is just a lack of time :) Sorry for that!

quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
…2583)

* CreateContainerCmd Link was outdated.

Replaced working link

* Replaced with version 3.0.0 link

* Updated to 3.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants