delegate getMetadata() to R2DBCDatabaseContainerProvider
#2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
reviewed
Apr 15, 2020
| @@ -68,8 +68,7 @@ | |||
|
|
|||
| @Override | |||
| public ConnectionFactoryMetadata getMetadata() { | |||
| // TODO check whether it is fine to call it without setting the host/port and other values | |||
kiview
approved these changes
Apr 15, 2020
mp911de
approved these changes
Apr 15, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…tainers#2577) Apparently, R2DBC ConnectionFactories perform early validation of options, and it fails because the original options (when specified as `r2dbc://mysql:///db`) miss some required options like host/port/username/password. After talking to Mark from R2DBC, it seems that the checks will stay, so we need to workaround it somehow. I ended up with the delegation to `R2DBCDatabaseContainerProvider`, because these provides should know which options they add and which are required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, R2DBC ConnectionFactories perform early validation of options, and it fails because the original options (when specified as
r2dbc://mysql:///db) miss some required options like host/port/username/password.After talking to @mp911de, it seems that the checks will stay, so we need to workaround it somehow. I ended up with the delegation to
R2DBCDatabaseContainerProvider, because these provides should know which options they add and which are required.Context:
https://twitter.com/bsideup/status/1250093434817347586?s=20