Regard specified VNC recording directory for BrowserWebDriverContainer again #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Apr 14, 2020
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
kiview
reviewed
Apr 14, 2020
| }, Optional.empty()); | ||
|
|
||
| String[] files = vncRecordingDirectory.list(new PatternFilenameFilter("PASSED-" + testName + "-.*\\.flv")); | ||
| assertTrue("Recorded file not found", files.length == 1); |
There was a problem hiding this comment.
Excellent addition to the test, thanks.
bsideup
reviewed
Apr 14, 2020
...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java
Outdated
Show resolved
Hide resolved
|
Hi @srempfer, Good catch! Sorry for letting it through. We thought this part is tested (it should be!) and did not bother double checking 😅 Extra points for adding a test - now it is tested :D |
srempfer
force-pushed
the
fixVncRecordingDirectoryHandling
branch
from
5f90aca
to
0810dab
Compare
bsideup
approved these changes
Apr 14, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…r again (testcontainers#2574) Co-authored-by: Stefan Rempfer <srempfer@rt.ipnt.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the changes of #2562 which were released with 1.14.0 the possibility to specify a target directory for the VNC recordings doesn't work anymore.