Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for startup strategy information/examples (#1157) #2565

Merged

Conversation

vcvitaly
Copy link
Contributor

Add a section 'Startup Strategies' to docs/features/startup_and_waits.md describing the default and 'one-shot' strategies, with a codeincluded example for the latter.

@rnorth
Copy link
Member

rnorth commented Apr 13, 2020

Thanks @vcvitaly - I'll have a read tomorrow.
Please ignore the CircleCI failures - that is a test reporting issue that we need to fix at our end 😬

@rnorth rnorth self-assigned this Apr 13, 2020
@bsideup
Copy link
Member

bsideup commented May 13, 2020

@rnorth ping

…containers/startupcheck/StartupCheckStrategyTest.java
@rnorth rnorth changed the title Add startup strategy information/examples to mkdocs #1157 Add docs for startup strategy information/examples (#1157) May 21, 2020
@rnorth rnorth merged commit c0fc42f into testcontainers:master May 21, 2020
@rnorth
Copy link
Member

rnorth commented May 21, 2020

Merged, thanks @vcvitaly!

rnorth added a commit that referenced this pull request May 21, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
…iners#2565)

* Add startup strategy information/examples to mkdocs #1157

* Update docs/examples/junit4/generic/src/test/java/org/testcontainers/containers/startupcheck/StartupCheckStrategyTest.java

Co-authored-by: Sergei Egorov <segorov@pivotal.io>
Co-authored-by: Richard North <rich.north@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants