VNC recording with BrowserWebdriverContainer in Spock-Extension #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about it, this is probably missing support for |
bsideup
reviewed
Apr 11, 2020
modules/spock/src/main/groovy/org/testcontainers/spock/SpockTestDescription.groovy
Show resolved
Hide resolved
bsideup
reviewed
Apr 11, 2020
modules/spock/src/main/groovy/org/testcontainers/spock/SpockTestDescription.groovy
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 11, 2020
modules/spock/src/main/groovy/org/testcontainers/spock/TestcontainersExtension.groovy
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 11, 2020
modules/spock/src/test/groovy/org/testcontainers/spock/BrowserVncRecordingIT.groovy
Show resolved
Hide resolved
bsideup
reviewed
Apr 11, 2020
modules/spock/src/main/groovy/org/testcontainers/spock/SpockTestDescription.groovy
Show resolved
Hide resolved
bsideup
reviewed
Apr 12, 2020
modules/spock/src/test/groovy/org/testcontainers/spock/BrowserVncRecordingIT.groovy
Show resolved
Hide resolved
bsideup
approved these changes
Apr 12, 2020
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…on (testcontainers#2548) Initially done as part of the Hackergarten at Gr8ConfEU 2018. Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this! Fixes #631.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #726.
Initially done as part of the Hackergarten at Gr8ConfEU 2018 (yes, that long ago 😅).
Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this 🙂 !
Fixes #631.