Use LogMessageWaitStrategy in VncRecordingContainer #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
approved these changes
Apr 10, 2020
|
🤯 this container predates the existence of We should do that...! I'd be OK with keeping this PR as-is, so that it can at least be released soon. |
|
All right, then I will change it to LogMessageWaitStrategy |
srempfer
force-pushed
the
vncRecorderTimeoutFix
branch
from
3480d41
to
e911925
Compare
kiview
approved these changes
Apr 11, 2020
bsideup
reviewed
Apr 11, 2020
core/src/test/java/org/testcontainers/containers/VncRecordingContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 11, 2020
core/src/test/java/org/testcontainers/containers/VncRecordingContainerTest.java
Outdated
Show resolved
Hide resolved
srempfer
force-pushed
the
vncRecorderTimeoutFix
branch
from
6c7e62f
to
2fd3809
Compare
|
Merging from master into the PR branch to incorporate #2557 and hopefully fix build. |
bsideup
approved these changes
Apr 12, 2020
bsideup
changed the title
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…s#2063) (testcontainers#2547) Co-authored-by: Stefan Rempfer <srempfer@rt.ipnt.de> Co-authored-by: Richard North <rich.north@gmail.com> Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run in the same issue as described here #2063
After some investigation I found out that the await timeout is to low in slow environments.
This happens also in my development environment - using Docker for Windows 2.2.0.5.
Unfortunately it tooks more than 1 second to retrieve the logs from the container and so the FrameConsumerResultCallback has no chance to count down the latch before the await timeout appears.
For my environment a await timeout of 2 seconds worked but I thought some more time couldn't hurt because it's only the worst case wait time and normally the logs should be retrieved faster.