Generate GitHub Actions CI Jobs automatically #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
force-pushed
the
generate-github-ci-1
branch
from
d04e514
to
e645c2c
Compare
bsideup
reviewed
Apr 5, 2020
|
|
||
| generate_preface | ||
| generate_job compile "build -x test" | ||
| generate_job core "testcontainers:check" compile |
There was a problem hiding this comment.
I wonder if shared compile (1 busy worker) actually helps. Have you done some measurements yet?
There was a problem hiding this comment.
It does not, so I removed it 😄
|
Indicative timings: A fully cached (S3 remote build cache) build: 6m25s A completely uncached build (with For the uncached build, the longest job, and therefore bottleneck is Therefore I think we could reduce the max build time to ~14mins by splitting up the JDBC testing for each DB into the relevant modules, to take advantage of parallelisation. Further performance gains could be possible by splitting up the |
Merged
rnorth
force-pushed
the
generate-github-ci-1
branch
from
e3ca0bc
to
12bb3bd
Compare
bsideup
reviewed
Apr 16, 2020
bsideup
approved these changes
Apr 17, 2020
rnorth
commented
Apr 18, 2020
Co-Authored-By: Richard North <rich.north@gmail.com>
rnorth
commented
Apr 18, 2020
rnorth
commented
Apr 18, 2020
Co-Authored-By: Richard North <rich.north@gmail.com>
rnorth
changed the title
rnorth
changed the title
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
Co-Authored-By: Sergei Egorov <bsideup@gmail.com> Co-Authored-By: Richard North <rich.north@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate GitHub Actions CI jobs for modules
Refs #2177, #1836
PR 1 of 2: this PR includes a script for generating the CI job configuration, but the script has to be manually run
A future PR should run the generation script automatically as a separate Action and commit changes, so that no manual updates are needed