Fallback to getDefaultGateway() if "bridge" is unavailable.
#2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NersesAM
reviewed
Mar 13, 2020
Comment on lines
+221
to
+223
| .orElseGet(() -> { | ||
| return DockerClientConfigUtils.getDefaultGateway().orElse("localhost"); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .orElseGet(() -> { | |
| return DockerClientConfigUtils.getDefaultGateway().orElse("localhost"); | |
| }); | |
| .orElseGet(() -> DockerClientConfigUtils.getDefaultGateway().orElse("localhost")); |
There was a problem hiding this comment.
No, thank you, it is done for readability :)
There was a problem hiding this comment.
ok, thought you had multiline lambda to begin with, but ended up in oneliner later on forgetting to remove the braces :)
There was a problem hiding this comment.
ah, no, just I don't like "long short lambdas" (lol). Thanks for suggesting anyways! 👍
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2239