Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka: replace deprecated poll method millis param with Duration #2318

Merged

Conversation

nshipyakov
Copy link
Contributor

No description provided.

@nshipyakov
Copy link
Contributor Author

Method poll with one long param from KafkaConsumer is deprecated

@rnorth rnorth changed the title deprecated poll method replaced to normal with duration Kafka: replace deprecated poll method millis param with Duration Feb 7, 2020
@rnorth
Copy link
Member

rnorth commented Feb 16, 2020

LGTM, thanks @nshipyakov!

@rnorth rnorth merged commit 7c8e0ea into testcontainers:master Feb 16, 2020
artjomka pushed a commit to artjomka/testcontainers-java that referenced this pull request Feb 28, 2020
@rnorth
Copy link
Member

rnorth commented Mar 5, 2020

Released in 1.13.0! Thanks for the contribution @nshipyakov 😃

@rnorth rnorth added this to the 1.13.0 milestone Mar 5, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants