Docker Compose: Add functionality to retrieve container by its name #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Jan 31, 2020
core/src/test/java/org/testcontainers/junit/DockerComposeContainerTest.java
Show resolved
Hide resolved
bsideup
reviewed
Jan 31, 2020
core/src/test/java/org/testcontainers/junit/DockerComposeContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Jan 31, 2020
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
bsideup
approved these changes
Feb 9, 2020
|
@artjomka merged! 🎉 Good job - thank you! |
rnorth
changed the title
|
Released in 1.13.0! Thanks for the contribution @artjomka 😃 |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
) Since `DockerComposeContainer#project` is private, there is currently no way of accessing containers started by Docker Compose. This change adds a new API to the DockerComposeContainer to obtain a `ContainerState` reference by the service's name. Fixes testcontainers#2302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2302