Improve checkMountableFile on Windows with unusual paths #2296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after update to newer Docker (i suspect it) I found that
checkMountableFile
check returns incorrect values for/dummy
volume.I have created PR to correctly resolve .jar resource mountable file from temp directory.
Problem is that when
org.testcontainers.utility.MountableFile#extractClassPathResourceToTempLocation
is called it callsjava.nio.file.Files#createTempDirectory
which resolves base temp dir fromjava.io.tmpdir
system property. My environment is shortened directory containing tilde in name which results in error from docker ... see below.What do you think about this fix?
Thx,
Ivos
my environment:
original exception/log