Add small delay in while loop to avoid spamming logs (ResourceReaper) #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Jan 24, 2020
|
|
||
| try { | ||
| // sleep for a moment to avoid excessive log spam | ||
| Thread.sleep(500); |
There was a problem hiding this comment.
we have RateLimiter available on classpath, could you please consider using it instead?
Also, 500ms is rather long initial delay.
… - Replaced Thread.sleep with RateLimiter
rnorth
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
This looks good to me - happy to approve.
Thanks for this @worldtiki.
artjomka
pushed a commit
to artjomka/testcontainers-java
that referenced
this pull request
Feb 28, 2020
…tcontainers#2287) * Add small delay in while loop to avoid spamming logs (ResourceReaper) * Add small delay in while loop to avoid spamming logs (ResourceReaper) - Replaced Thread.sleep with RateLimiter
|
Released in 1.13.0! Thanks for the contribution @worldtiki 😃 |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…tcontainers#2287) * Add small delay in while loop to avoid spamming logs (ResourceReaper) * Add small delay in while loop to avoid spamming logs (ResourceReaper) - Replaced Thread.sleep with RateLimiter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.