Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set sourceJar.from=allSource for modules/spock #2281

Merged
merged 2 commits into from Feb 16, 2020
Merged

Set sourceJar.from=allSource for modules/spock #2281

merged 2 commits into from Feb 16, 2020

Conversation

pertu
Copy link
Contributor

@pertu pertu commented Jan 23, 2020

Fixes issue #2280
By default, sourceJar.from = allJava (see gradle/publishing.gradle)
But Spock module is in Groovy
=> sourceJar.from should be allGroovy/allSource

Set sourceJar.from=allSource for modules/spock
088b088 
Fixes issue #2280
By default, sourceJar.from = allJava (see gradle/publishing.gradle)
But Spock module is in Groovy
  => sourceJar.from should be allGroovy/allSource
rnorth
rnorth approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pertu - this looks sensible.
Thank you for the contribution.

@rnorth rnorth merged commit 6f7b17a into testcontainers:master Feb 16, 2020
artjomka pushed a commit to artjomka/testcontainers-java that referenced this pull request Feb 28, 2020
@pertu @rnorth
Set sourceJar.from=allSource for modules/spock (testcontainers#2281)
cedd6fe 
Fixes issue testcontainers#2280
By default, sourceJar.from = allJava (see gradle/publishing.gradle)
But Spock module is in Groovy
  => sourceJar.from should be allGroovy/allSource

Co-authored-by: Richard North <rich.north@gmail.com>
@rnorth rnorth added this to the 1.13.0 milestone Mar 5, 2020
@rnorth
Copy link
Member

rnorth commented Mar 5, 2020

Released in 1.13.0! Thanks for the contribution @pertu 😃

@pertu pertu deleted the fix-spock-module-sources-jar branch March 6, 2020 13:21
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
@pertu @rnorth @quincy
Set sourceJar.from=allSource for modules/spock (testcontainers#2281)
416a7b4 
Fixes issue testcontainers#2280
By default, sourceJar.from = allJava (see gradle/publishing.gradle)
But Spock module is in Groovy
  => sourceJar.from should be allGroovy/allSource

Co-authored-by: Richard North <rich.north@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pertu @rnorth