Expand Container dependsOn parameters to accept Iterable
#2259
Conversation
| @@ -26,9 +26,6 @@ | |||
| import lombok.Setter; | |||
| import lombok.SneakyThrows; | |||
| import org.apache.commons.codec.digest.DigestUtils; | |||
| import org.apache.commons.compress.archivers.tar.TarArchiveInputStream; | |||
There was a problem hiding this comment.
Note that there seem to be a lot of import movements. I'm not sure why this is suddenly happening, but I'm confident that the .editorconfig rules we have set up are being respected:
[*.java]
indent_style = space
indent_size = 4
# Never use star imports
ij_java_names_count_to_use_import_on_demand = 99
ij_java_class_count_to_use_import_on_demand = 99
ij_java_layout_static_imports_separately = true
Maybe recent edits to these files have not been picking up the rules?
| */ | ||
| public SELF dependsOn(List<Startable> startables) { | ||
| dependencies.addAll(startables); | ||
| public SELF dependsOn(Iterable<? extends Startable> startables) { |
There was a problem hiding this comment.
this will break binary compatibility
There was a problem hiding this comment.
Pushing a commit now to reinstate dependsOn(List)
rnorth
dismissed
kiview’s stale review
@bsideup had concerns, hopefully now resolved
| @@ -27,8 +30,8 @@ public Thread newThread(Runnable r) { | |||
| /** | |||
| * @see #deepStart(Stream) | |||
| */ | |||
| public CompletableFuture<Void> deepStart(Collection<? extends Startable> startables) { | |||
| return deepStart(startables.stream()); | |||
| public CompletableFuture<Void> deepStart(Iterable<? extends Startable> startables) { | |||
There was a problem hiding this comment.
Whoops, japicmp has flagged this!
Just as we did in GenericContainer, I'll reinstate the previous method signature for binary compatibility.
rnorth
changed the title
dependsOn parameters to accept IterabledependsOn parameters to accept Iterable
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 |
…tainers#2259) * Expand `dependsOn` parameters to accept `Iterable` * Reinstate a `dependsOn(List)` method, for binary backwards compatibility * Reinstate `deepStart(Collection<? extends Startable>)` method
Builds upon #2221 so that any
Iterableis allowed as adependsOnargument.Suggested by @bsideup