Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept List<GenericContainer> in deepStart #2221

Merged
merged 1 commit into from Jan 18, 2020
Merged

Accept List<GenericContainer> in deepStart #2221

merged 1 commit into from Jan 18, 2020

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Jan 3, 2020

No description provided.

rnorth
rnorth approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible - thanks for the contribution!

@rnorth rnorth merged commit 7143939 into testcontainers:master Jan 18, 2020
@findepi findepi deleted the findepi/master/accept-list-genericcontainer-in-deepstart-6731b1 branch January 18, 2020 14:20
@rnorth rnorth mentioned this pull request Jan 18, 2020
Merged
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
@findepi @quincy
Accept List<GenericContainer> in deepStart (testcontainers#2221)
fc07bc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@findepi @rnorth