Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache results of auth lookups #2213

Merged
merged 1 commit into from Apr 4, 2020
Merged

Cache results of auth lookups #2213

merged 1 commit into from Apr 4, 2020

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Dec 26, 2019

Small performance optimization (saves perhaps <=300ms every time an image is referenced, even if it is not ultimately pulled).

bsideup
bsideup approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bsideup bsideup added this to the next milestone Mar 13, 2020
@rnorth rnorth merged commit 7eced8b into master Apr 4, 2020
@rnorth rnorth deleted the cache-auth branch April 4, 2020 19:46
@rnorth
Copy link
Member Author

rnorth commented Apr 13, 2020

This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉

quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
@rnorth @quincy
Cache results of auth lookups (testcontainers#2213)
8eaa1f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnorth @bsideup