Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix framing in OkHttp transport #2155

Merged
merged 1 commit into from Dec 14, 2019
Merged

Fix framing in OkHttp transport #2155

merged 1 commit into from Dec 14, 2019

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Dec 6, 2019

we were skipping first 8 bytes in case of a RAW stream

@bsideup
Fix framing in OkHttp transport
af449d7 
we were skipping first 8 bytes in case of a RAW stream
@bsideup bsideup added this to the next milestone Dec 6, 2019
@bsideup bsideup requested a review from a team December 6, 2019 11:21
@bsideup
Copy link
Member Author

bsideup commented Dec 6, 2019

Future reading:
https://github.com/moby/moby/blob/3ce9258447e61233047a236aae03d6ccb1f2a758/pkg/stdcopy/stdcopy.go#L94

rnorth
rnorth approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, and I can see that it fixes a possible bug in the raw stream handling.

Are there any bug repro tests we could introduce? As we're backporting to docker-java, perhaps the test would belongs there anyway.

@bsideup bsideup merged commit 6e1d211 into master Dec 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_okhttp_framing branch December 14, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.12.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @rnorth