Add example for nginx module #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldtiki
commented
Nov 2, 2019
|
|
||
| /** | ||
| * @author richardnorth | ||
| */ | ||
| public class SimpleNginxTest { | ||
|
|
||
| private static File contentFolder = new File(System.getProperty("user.home") + "/.tmp-test-container"); | ||
| private static String tmpDirectory = System.getProperty("user.home") + "/.tmp-test-container"; |
There was a problem hiding this comment.
Had to shift some things a bit to be able to include the test in the docs.
worldtiki
commented
Nov 2, 2019
| contentFolder.mkdir(); | ||
| contentFolder.setReadable(true, false); |
There was a problem hiding this comment.
I couldn't find a reason why these were being set. I'm happy to put them back but for the purposes of a test/demo I don't think they are required.
worldtiki
commented
Nov 2, 2019
|
|
||
| URLConnection urlConnection = nginx.getBaseUrl("http", 80).openConnection(); | ||
| private static String responseFromNginx(URL baseUrl) throws IOException { |
There was a problem hiding this comment.
This could be done inline but I moved to a separate method to make the example more readable.
rnorth
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
Thanks for the contribution, @worldtiki - this looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.