Example and docs for ability to copy to and from container for #1164

[sumitanvekar]

Created example to demonstrate ability to copy to and from container using Generic Container.
Added example into advanced_options section.

Created for #1164

[rnorth]

This is cool, thank you @sumitanvekar!

I think my main item of feedback would be to ask for this to appear in the features/files.md docs page - it should be its own section in the 'Files and volumes' page.

[sumitanvekar]

@rnorth moved docs to files.md as per your comment. Thanks for your review!

[sumitanvekar]

Couple tests fails for no apparent reason (from logs, they seemed to be flaky tests). So, I did an empty commit to trigger checks again.

[bsideup]

@sumitanvekar please do not trigger full CI if you see some flaky tests, it creates a big load on our CI environments.
Instead, we will rerun the tests of that particular module when we see it during the review.

[bsideup]

There are tests (in core/) for copy to/from already, no need to have a separate one in docs/examples. I think we should refer them from the docs and maybe cleanup a bit to make them look better in the docs.

[sumitanvekar]

@bsideup I am not sure if we should use core test class for documentation since they will get polluted with commented code blocks which are required for documentation. However, if we are planning to get rid of all docs example code to avoid duplication, I will update pr with your recommendations.

On a separate note, do you want to add a section in contributing.md to mention about the flaky tests and process for that? That will help newbies. Happy to do a separate pr for it.

[rnorth]

Looks like there are some missing imports in CopyFileToContainerTest

[rnorth]

I've pushed fixed imports to the source branch.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[sumitanvekar]

@rnorth @bsideup any chance this can get merged? Or does it need something?

[rnorth]

Let's merge it - sorry @sumitanvekar that this has taken so long.

[rnorth]

Has been updated per requests.

[rnorth]

Ohoh, this has broken our build on Windows. I'll revert, and fix up.