Separate "environment" and "classpath" properties (for global things) #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
commented
Aug 25, 2019
| @@ -71,13 +82,18 @@ public String getPulsarImage() { | |||
| } | |||
|
|
|||
| public boolean isDisableChecks() { | |||
| return Boolean.parseBoolean((String) properties.getOrDefault("checks.disable", "false")); | |||
| return Boolean.parseBoolean((String) environmentProperties.getOrDefault("checks.disable", "false")); | |||
There was a problem hiding this comment.
was never supposed to be disabled in classpath' file, but some users were misusing it and setting it "for everyone".
bsideup
commented
Aug 25, 2019
| } | ||
|
|
||
| public String getDockerClientStrategyClassName() { | ||
| return (String) properties.get("docker.client.strategy"); | ||
| return (String) environmentProperties.get("docker.client.strategy"); |
There was a problem hiding this comment.
does not make sense to have it "for everyone" as well since it is strictly environment specific
rnorth
approved these changes
Aug 26, 2019
delete-merged-branch
bot
deleted the
separate_environment_and_classpath_properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the "transportType" check because Netty is no longer supported