Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude jna transitive dependency from visible-assertions to reconcile versions #1744

Merged
merged 3 commits into from Aug 25, 2019

Conversation

eggilbert
Copy link
Contributor

We use the dependencyConvergence rule as part of the maven-enforcer-plugin to ensure that there is no ambiguity in the versions of our dependency tree.

As of #1437, Testcontainers appears to be bringing in two different transitive versions of net.java.dev.jna:jna:

  • 5.2.0 via org.rnorth.visible-assertions:visible-assertions:2.1.2
  • 5.3.1 via net.java.dev.jna:jna-platform:5.3.1

The latter is controlled in the project directly and seems like the one that is desired?

Here is an example of the error that is received when we don't exclude jna from the testcontainers dependency in our pom.xml and include jna directly ourselves:

Dependency convergence error for net.java.dev.jna:jna:5.2.0 paths to dependency are:
+-my.group:my.artifact:my.version
  +-org.testcontainers:testcontainers:1.12.0
    +-org.rnorth.visible-assertions:visible-assertions:2.1.2
      +-net.java.dev.jna:jna:5.2.0
and
+-my.group:my.artifact:my.version
  +-org.testcontainers:testcontainers:1.12.0
    +-net.java.dev.jna:jna-platform:5.3.1
      +-net.java.dev.jna:jna:5.3.1

@bsideup bsideup added this to the next milestone Aug 25, 2019
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsideup bsideup merged commit ad5f1f6 into testcontainers:master Aug 25, 2019
@bsideup
Copy link
Member

bsideup commented Aug 25, 2019

@eggilbert merged, thanks! 👍

@eggilbert
Copy link
Contributor Author

👍

@eggilbert eggilbert deleted the jna branch August 26, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants