Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven Central as a fallback for dependency download #1710

Merged
merged 1 commit into from Aug 6, 2019

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Aug 6, 2019

To reduce flaky CI builds when JCenter is experiencing a blip

Example failure from Travis:

> Task :rabbitmq:compileTestJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Could not resolve all files for configuration ':rabbitmq:testCompileClasspath'.
> Could not resolve org.assertj:assertj-core:3.12.2.
  Required by:
      project :rabbitmq
   > Could not resolve org.assertj:assertj-core:3.12.2.
      > Could not parse POM https://jcenter.bintray.com/org/assertj/assertj-core/3.12.2/assertj-core-3.12.2.pom
         > Could not resolve org.junit:junit-bom:5.4.0.
            > Could not resolve org.junit:junit-bom:5.4.0.
               > Could not get resource 'https://jcenter.bintray.com/org/junit/junit-bom/5.4.0/junit-bom-5.4.0.pom'.
                  > Could not GET 'https://jcenter.bintray.com/org/junit/junit-bom/5.4.0/junit-bom-5.4.0.pom'.
                     > Read timed out

I'd estimate this kind of failure accounts for ~20% of the CI jobs that I have to re-run, and it's a waste to have to do so.

If we use Maven Central as a fallback, I believe that our builds should be more stable.

To reduce flaky CI builds when JCenter is experiencing a blip
@bsideup
Copy link
Member

bsideup commented Aug 6, 2019

@rnorth seems to be failing, but due to the plugin resolution :D

@rnorth rnorth merged commit 8042f9c into master Aug 6, 2019
@rnorth rnorth deleted the add-mavencentral-repository branch August 6, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants