Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose.yml to simplify local doc development #1653

Merged
merged 4 commits into from Aug 6, 2019

Conversation

mikesir87
Copy link
Contributor

While doing docs development, I found it easier to run everything via containers to prevent the need to setup virtualenv/python on my machine. So, figured I'd offer it back in case it might be useful and help lower the barrier for someone else!

@rnorth
Copy link
Member

rnorth commented Aug 2, 2019

Ah thank you @mikesir87 - this is a good idea!

docs/contributing_docs.md Outdated Show resolved Hide resolved
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, just spotted a slight typo. As it looks like I don't have permission to push back to your PR/fork, I'll leave as a suggested change for now.

Thanks!

@rnorth rnorth merged commit fbf5092 into testcontainers:master Aug 6, 2019
@rnorth
Copy link
Member

rnorth commented Aug 6, 2019

Thanks for the contribution @mikesir87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants