Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScriptUtils splitting with Windows EOF #1467

Merged
merged 2 commits into from May 18, 2019
Merged

Fix ScriptUtils splitting with Windows EOF #1467

merged 2 commits into from May 18, 2019

Conversation

ppfeiler
Copy link
Contributor

This fixes the following issue: #1465

@rnorth
Copy link
Member

rnorth commented May 15, 2019

Thank you @ppfeiler. I think CircleCI/Maven Central was having a wobble, so I've restarted the CI build.

@rnorth rnorth added this to the next milestone May 18, 2019
@rnorth
Copy link
Member

rnorth commented May 18, 2019

Thanks @ppfeiler - will merge shortly!

@rnorth rnorth changed the title issue 1465: fix ScriptUtils splitting with Windows EOF Fix ScriptUtils splitting with Windows EOF May 18, 2019
@rnorth
Copy link
Member

rnorth commented May 18, 2019

Merging now. Fixes #1465

@rnorth rnorth changed the title Fix ScriptUtils splitting with Windows EOF Fix ScriptUtils splitting with Windows EOF (#1467, #1465) May 18, 2019
@rnorth rnorth merged commit e4ce8f5 into testcontainers:master May 18, 2019
@rnorth rnorth changed the title Fix ScriptUtils splitting with Windows EOF (#1467, #1465) Fix ScriptUtils splitting with Windows EOF May 18, 2019
@ppfeiler ppfeiler deleted the ppfeiler/fixScriptUtilsWithWindowsLineEndings branch May 20, 2019 12:56
@rnorth rnorth modified the milestones: next, 1.11.3 May 21, 2019
@rnorth
Copy link
Member

rnorth commented May 21, 2019

Released in 1.11.3. Thanks for the contribution!

@strawberry-choco strawberry-choco mentioned this pull request May 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.11.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppfeiler @rnorth