Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespaces are truncated from text values in init script in presence of C style comments #1452

Closed
ParafeniukMikalaj opened this issue May 6, 2019 · 3 comments · Fixed by #1702

Comments

@ParafeniukMikalaj
Copy link

Hi, I noticed, that test-containers removes whitespace characters from VARCHAR values in init script when C style comments are present.

Please check sample project demonstrating a problem: https://github.com/ParafeniukMikalaj/testcontainers-jdbc-test

@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Aug 4, 2019
@rnorth
Copy link
Member

rnorth commented Aug 4, 2019

Not stale. Let’s check this again - if it’s not fixed in the latest improvements to ScriptUtils, we should add a test case and fix it.

@rnorth
Copy link
Member

rnorth commented Aug 4, 2019

Sorry for leaving this so long @ParafeniukMikalaj. I've created a quick test case in #1702, which I believe is equivalent to your repro example and shows that the problem is no longer occurring. Please have a look if you have time.

Thank you for taking the time to report the issue and develop a repro example back in May; if this had still been a problem it would certainly have been important to fix, and having a test for this now lets us guard against regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants