Fix fixed host port test #1355
Merged
Fix fixed host port test #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge base
…ainer, followed path of original test;
|
crap, you are not using assertj in testCompile. People are crying :) |
…in response getting now fails test directly with io exc
bsideup
reviewed
Apr 3, 2019
core/src/test/java/org/testcontainers/junit/FixedHostPortContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 3, 2019
core/src/test/java/org/testcontainers/junit/FixedHostPortContainerTest.java
Outdated
Show resolved
Hide resolved
…to alpine, also copied some routines from generic container tests
bsideup
reviewed
Apr 3, 2019
core/src/test/java/org/testcontainers/junit/FixedHostPortContainerTest.java
Show resolved
Hide resolved
bsideup
reviewed
Apr 3, 2019
core/src/test/java/org/testcontainers/junit/FixedHostPortContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 3, 2019
core/src/test/java/org/testcontainers/junit/FixedHostPortContainerTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 3, 2019
| // assertEquals("The bucket content was successfully set", "foo", redisson.getBucket("test").get()); | ||
| // assertEquals("The container returns the fixed port from getMappedPort(...)", freePort, redis.getMappedPort(REDIS_PORT)); | ||
| final Integer unusedHostPort; | ||
| String content; |
…code style updates based on PR
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
|
Hmm, I don't think we should have let this get stale - reopening. Sorry @glebsts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child of this slack thread
Before:
FixedHostPortContainerTestbasically just started redis two times without any assertions. Test used redis container and had some cryptic commented-out assertion flow, so nothing was actually tested except for "container starts", in theory throwing undeterminedIOExceptionin case of any failure.Now: test starts container with simple open-source http echo server image [1] [2], validates that port ia accessible, stops, takes "free to use host port" and starts container again with fixed host port, validates that port is accessible.
Added as much javadoc and assertion descriptions as I could. Hopefully codestyle is ok, or I will fix it based on any report provided.
Any comments are much appreciated.
As far as I can see, since my last PR changelog is not used anymore, so guess I don't need to add any notes.