Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get exitcode from inspectExecCmd #1318

Merged
merged 6 commits into from
Mar 18, 2019
Merged

get exitcode from inspectExecCmd #1318

merged 6 commits into from
Mar 18, 2019
+21 −21

Conversation

dmarkhas
Copy link
Contributor

@dmarkhas dmarkhas commented Mar 18, 2019 •
edited

Addresses #1309

bsideup and others added 3 commits March 18, 2019 11:37
@bsideup bsideup added this to the next milestone Mar 18, 2019
@bsideup
Copy link
Member

bsideup commented Mar 18, 2019

@dmarkhas

FYI I've pushed a small change (Lombok's @Value and added a now-deprecated constructor to avoid a breaking change).

Happy to merge after the CI reports green status, good job 👍

@dmarkhas
Copy link
Contributor Author

Thanks @bsideup , I did not find any other usages of this class in the project, and since it is not public I assumed it is safe to change the ctor signature.

@bsideup
Copy link
Member

bsideup commented Mar 18, 2019

@dmarkhas it is public (defined as an inner class of an interface)

@dmarkhas
Copy link
Contributor Author

Right, sorry :)

@bsideup
Copy link
Member

bsideup commented Mar 18, 2019

@dmarkhas oh, no problem :)
That was actually an issue on our side (public constructor for a result-holding class), good that we fixed it as part of this PR 👍

@bsideup bsideup merged commit 43e971f into testcontainers:master Mar 18, 2019
@bsideup
Copy link
Member

bsideup commented Mar 18, 2019

@dmarkhas merged, thanks! 👍

@dmarkhas dmarkhas mentioned this pull request Mar 18, 2019
Merged
@rnorth
Copy link
Member

rnorth commented Mar 22, 2019

Releasing this in 1.11.0 🎉

@ValentinParamonov ValentinParamonov mentioned this pull request Oct 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup left review comments

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmarkhas @bsideup @rnorth