Remove netty transport, rework shading #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/build.gradle
kiview
approved these changes
Mar 15, 2019
rnorth
reviewed
Mar 17, 2019
| project.afterEvaluate { | ||
| dependencies { | ||
| for (id in project.configurations.compile.resolvedConfiguration.resolvedArtifacts*.moduleVersion*.id) { | ||
| exclude(dependency("${id.group}:${id.name}")) |
There was a problem hiding this comment.
This is interesting - what's this doing? It looks like we're excluding all transitive deps. Is this in order to make all deps explicit?
There was a problem hiding this comment.
Read it as: "shade everything, except the dependencies from the compile scope". It means that if docker-java adds a dependency on X, it will never appear in our dependencies unless we add it to compile scope (aka add it as a public dependency of the library)
rnorth
approved these changes
Mar 17, 2019
|
Would you like to do the honours and merge, @bsideup? 😄 |
This was referenced Mar 18, 2019
|
@rnorth :D yeah, waiting for CI status after the master merge, will merge shortly after |
|
Releasing this in 1.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running OkHttp transport by default since version 1.9.0 without any (reported) issues.
Since Netty shading caused some problems in the past (especially with native dependencies), it doesn't make sense to keep it as an alternative transport because there aren't any features that supported by Netty but not by OkHttp.
Note that once docker-java is split into modules, we should contribute the OkHttp transport back to docker-java and remove the shading all together.