Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for MongoDB containers #1288

Merged
merged 3 commits into from May 16, 2019
Merged

Added example for MongoDB containers #1288

merged 3 commits into from May 16, 2019

Conversation

slu-it
Copy link
Contributor

@slu-it slu-it commented Mar 2, 2019

New PR since the old PR branch (#803) got deleted by accident ... This time as an example.

@slu-it slu-it mentioned this pull request Mar 2, 2019
Closed
@kiview
Copy link
Member

kiview commented Mar 3, 2019

Travis fails of because of Gradle build scan, not really related to this PR:
https://travis-ci.org/testcontainers/testcontainers-java/jobs/500799968#L754

kiview
kiview requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks.
Just some minor remarks.

If you like, you can also include this example into the actual docs in a later PR (not mandatory of course).

examples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainer.java Outdated Show resolved Hide resolved
examples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainer.java Outdated Show resolved Hide resolved
...ples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainerTest.java Outdated Show resolved Hide resolved
@rnorth rnorth changed the title Added support for MongoDB containers Added example for MongoDB containers Mar 3, 2019
@slu-it
Copy link
Contributor Author

slu-it commented Mar 4, 2019

@kiview implemented your suggestions and also updated #804 the same way
I'll have a look at the docs at a later time.

@sullis
Copy link
Contributor

sullis commented Apr 22, 2019

@slu-it is this PR still under development? Is it ready for review?

@slu-it
Copy link
Contributor Author

slu-it commented Apr 22, 2019

@sullis the PR is ready for review - I might have worded my last comment a little bit vague. I meant to say that I would take a look at the documentation suggestion in another PR at a later time

sullis
sullis reviewed Apr 22, 2019
View reviewed changes
examples/mongodb-container/src/test/java/org/testcontainers/containers/MongoDbContainer.java Outdated
* {@link #setPortBindings(java.util.List)}.
*/
public static final int MONGODB_PORT = 27017;
public static final String DEFAULT_IMAGE_AND_TAG = "mongo:4.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MongoDB's versioning scheme is described here:

https://docs.mongodb.com/manual/release-notes/#release-version-numbers

Release series ending with even numbers (e.g. 4 above) are stable and ready for production, while odd numbers are for development and testing only.

IMO -- the default image should be "mongo:4.0" (a stable, production ready version)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT? @slu-it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sullis i changed it to version 4.0 - did not know about MongoDB's "interesting" version schema.

@sullis
Copy link
Contributor

sullis commented Apr 29, 2019

LGTM. can we merge this?

@slu-it
Copy link
Contributor Author

slu-it commented Apr 30, 2019

Yes

@sullis
Copy link
Contributor

sullis commented May 1, 2019

can we merge this today?

@sullis
Copy link
Contributor

sullis commented May 6, 2019

LGTM @slu-it

@slu-it
Copy link
Contributor Author

slu-it commented May 6, 2019

@sullis LGTM as well, but I'm not a committer .. @kiview, @rnorth or @bsideup need to press the button (?)

@sullis
Copy link
Contributor

sullis commented May 15, 2019

can we merge this? @kiview @rnorth @slu-it

@kiview
Copy link
Member

kiview commented May 16, 2019

Thanks for the work @slu-it and @sullis,
I'll check in with the others and will merge afterwards.

@kiview kiview self-assigned this May 16, 2019
@kiview kiview added this to the next milestone May 16, 2019
@kiview kiview merged commit 03f8caa into testcontainers:master May 16, 2019
@kiview
Copy link
Member

kiview commented May 16, 2019

Merged, thanks @slu-it for sticking with this for a longer time 🙂

@slu-it slu-it deleted the mongodb branch May 17, 2019 16:01
@slu-it
Copy link
Contributor Author

slu-it commented May 17, 2019

thank you for merging :)

@rnorth rnorth modified the milestones: next, 1.11.3 May 21, 2019
@rnorth
Copy link
Member

rnorth commented May 21, 2019

Released in 1.11.3. Thanks for the contribution!

@bsideup bsideup mentioned this pull request Jun 12, 2019
Closed
@bsideup bsideup mentioned this pull request Jun 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sullis sullis sullis left review comments

@bsideup bsideup bsideup approved these changes

@kiview kiview kiview approved these changes

@rnorth rnorth Awaiting requested review from rnorth

Assignees

@kiview kiview

Labels
type/docs
Projects
None yet
Milestone
1.11.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slu-it @kiview @sullis @rnorth @bsideup