Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "copy" strategy in withClasspathResourceMapping #1163

Closed
bsideup opened this issue Jan 20, 2019 · 3 comments
Closed

Use "copy" strategy in withClasspathResourceMapping #1163

bsideup opened this issue Jan 20, 2019 · 3 comments
Labels
help wanted resolution/acknowledged

Comments

@bsideup
Copy link
Member

bsideup commented Jan 20, 2019

Since withClasspathResourceMapping is immutable (one can't change the classpath element, also we extract it into a temporary folder), IMO it makes sense to use copyToContainer instead of file system mounting
@bsideup bsideup mentioned this issue Jan 20, 2019
Merged
@stale
Copy link

stale bot commented Apr 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Apr 25, 2019
@stale
Copy link

stale bot commented May 9, 2019

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.

@stale stale bot closed this as completed May 9, 2019
@bsideup bsideup reopened this Aug 29, 2019
@stale stale bot removed the stale label Aug 29, 2019
@bsideup bsideup mentioned this issue Aug 29, 2019
Merged
@bsideup
Copy link
Member Author

bsideup commented Jan 31, 2020

Fixed in #1814

@bsideup bsideup closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted resolution/acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsideup