Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New docs: Startup strategy information/examples #1157

Open
rnorth opened this issue Jan 19, 2019 · 5 comments
Open

New docs: Startup strategy information/examples #1157

rnorth opened this issue Jan 19, 2019 · 5 comments
Labels
help wanted type/docs

Comments

@rnorth
Copy link
Member

rnorth commented Jan 19, 2019

Improvement for the new mkdocs-based documentation.

Add a section 'Startup Strategies' to docs/features/startup_and_waits.md describing the default and 'one-shot' strategies, with a codeincluded example for the latter.
@stale
Copy link

stale bot commented Apr 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Apr 19, 2019
@bsideup bsideup removed the stale label Apr 19, 2019
@stale
Copy link

stale bot commented Jul 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jul 18, 2019
@stale
Copy link

stale bot commented Aug 1, 2019

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.

@stale stale bot closed this as completed Aug 1, 2019
@rnorth rnorth reopened this Aug 3, 2019
@stale stale bot removed the stale label Aug 3, 2019
@vcvitaly
Copy link
Contributor

vcvitaly commented Apr 9, 2020 •
edited

@rnorth Is it still open for contribution? I'd like to take that up

@bsideup
Copy link
Member

bsideup commented Apr 9, 2020

@vcvitaly sure! 👍

rnorth added a commit that referenced this issue May 21, 2020
@vcvitaly @bsideup @rnorth
Add docs for startup strategy information/examples (#1157) (#2565)
c0fc42f 
* Add startup strategy information/examples to mkdocs #1157

* Update docs/examples/junit4/generic/src/test/java/org/testcontainers/containers/startupcheck/StartupCheckStrategyTest.java

Co-authored-by: Sergei Egorov <segorov@pivotal.io>
Co-authored-by: Richard North <rich.north@gmail.com>
rnorth added a commit that referenced this issue May 21, 2020
@rnorth
Revert "Add docs for startup strategy information/examples (#1157) (#…
4459860 
…2565)"

This reverts commit c0fc42f.
rnorth added a commit that referenced this issue May 21, 2020
@rnorth
Revert "Add docs for startup strategy information/examples (#1157)" (#…
4ba01a6 
…2776)
rnorth added a commit that referenced this issue May 21, 2020
@rnorth
Revert "Revert "Add docs for startup strategy information/examples (#…
aae9b3e 
…1157)" (#2776)"

This reverts commit 4ba01a6.
quincy referenced this issue in quincy/testcontainers-java May 28, 2020
@vcvitaly @bsideup
@rnorth @quincy
Add docs for startup strategy information/examples (#1157) (testconta…
e0959aa 
…iners#2565)

* Add startup strategy information/examples to mkdocs #1157

* Update docs/examples/junit4/generic/src/test/java/org/testcontainers/containers/startupcheck/StartupCheckStrategyTest.java

Co-authored-by: Sergei Egorov <segorov@pivotal.io>
Co-authored-by: Richard North <rich.north@gmail.com>
quincy referenced this issue in quincy/testcontainers-java May 28, 2020
@rnorth @quincy
Revert "Add docs for startup strategy information/examples (#1157)" (t…
21366c0 
…estcontainers#2776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rnorth @bsideup @vcvitaly