fix: do not create garbage in examples nav bar #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
chore
eddumelendez
approved these changes
Dec 5, 2022
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Dec 15, 2022
* main: chore: generate dependabot configs for examples (testcontainers#654) chore: format dependabot using go-yaml indents (testcontainers#658) chore(deps): bump github.com/docker/compose/v2 from 2.12.2 to 2.14.0 (testcontainers#657) chore(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (#583) chore(deps): bump github.com/cenkalti/backoff/v4 from 4.1.3 to 4.2.0 (testcontainers#656) chore: remove quotes from dependabot updates (testcontainers#655) fix: do not create garbage in examples nav bar (testcontainers#652) chore(deps): bump github.com/containerd/containerd from 1.6.8 to 1.6.10 (#621) chore(deps): bump golang.org/x/sys from 0.1.0 to 0.3.0 (testcontainers#651)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes how the nav bar for the examples is generated, not appending the examples to the "non"-empty array that the generator created to define the examples nav bar.
Why is it important?
It added empty elements to the nav bar, that the user must remove before submitting the example
Related issues