Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document replace directive for Docker Compose #632

Merged
merged 3 commits into from Nov 22, 2022

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Nov 21, 2022

What does this PR do?

It documents the replace directive that is needed to be added after the v0.16.0 release.

Why is it important?

It could create confusion if not documented, as expressed in #629

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner November 21, 2022 17:15
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Nov 21, 2022
@mdelapenya mdelapenya self-assigned this Nov 21, 2022
@mdelapenya mdelapenya requested a review from a team November 21, 2022 17:15
docs/quickstart/gotest.md Outdated Show resolved Hide resolved
Copy link

@cyberbeast cyberbeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya mdelapenya merged commit bc4cec8 into testcontainers:main Nov 22, 2022
@mdelapenya mdelapenya deleted the document-replace branch November 22, 2022 16:04
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Nov 23, 2022
* main:
  chore: bump version in mkdocs (#630)
  docs: remove code snippets from main README (testcontainers#631)
  docs: document replace directive for Docker Compose (testcontainers#632)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Nov 29, 2022
* main:
  Add toxiproxy example (testcontainers#643)
  Add spanner example (testcontainers#642)
  chore: sync governance files (testcontainers#641)
  Add pubsub example (testcontainers#640)
  chore: adjust generator for the docs site (testcontainers#639)
  Add datastore example (testcontainers#638)
  Add firestore example (testcontainers#637)
  fix: avoid panics when checking container state and container.raw is nil (testcontainers#635)
  feat: provide a tool to generate examples from code (#618)
  chore: bump version in mkdocs (#630)
  docs: remove code snippets from main README (testcontainers#631)
  docs: document replace directive for Docker Compose (testcontainers#632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot import testcontainers-go without locking to specific versions of indirect dependencies
2 participants